From theseas!fs.Princeton.EDU!cek Fri, 19 Feb 93 01:28:51 EET
Received: by kriton.UUCP (V1.16/Amiga)
	id AA00000; Fri, 19 Feb 93 01:28:51 EET
Received: by theseas.ntua.gr with UUCP; Thu, 18 Feb 93 18:37:17 +0200
Received: from mcsun.EU.net by pythia.ics.forth.gr via ITEnet with SMTP;
	id AA04290 (5.65c/FORTH-ICS-3.0-MHS-7.0); Thu, 18 Feb 1993 17:27:05 +0200
Received: by mcsun.EU.net via EUnet
	id AA28891 (5.65b/CWI-2.206); Thu, 18 Feb 1993 16:24:26 +0100
Received: from Princeton.EDU by relay1.UU.NET with SMTP 
	(5.61/UUNET-internet-primary) id AA04902; Thu, 18 Feb 93 10:23:34 -0500
Received: from fs.Princeton.EDU by Princeton.EDU (5.65b/2.95/princeton)
	id AA07598; Thu, 18 Feb 93 10:18:36 -0500
Received: by fs.Princeton.EDU (4.1/1.105)
	id AA09842; Thu, 18 Feb 93 10:18:37 EST
Received: from faui45.informatik.uni-erlangen.de by fs.Princeton.EDU (4.1/1.105)
	id AA09741; Thu, 18 Feb 93 10:17:27 EST
Received: from faui43.informatik.uni-erlangen.de by uni-erlangen.de with SMTP;
	id AA00379 (5.65c-5/7.3r-FAU); Thu, 18 Feb 1993 16:17:20 +0100
Received: by immd4.informatik.uni-erlangen.de;
	id AA11568 (5.65c-5/7.3m-FAU); Thu, 18 Feb 1993 16:17:19 +0100
Message-Id: <199302181517.AA11568@faui43.informatik.uni-erlangen.de>
Date: Thu, 18 Feb 93 16:17:17 MET
X-Mailer: ELM [version 2.3 PL11]
Errors-To: Princeton.EDU!cek
Remailed-Date: Thu Feb 18 10:17:51 EST 1993
From: "Michael Schroeder (Inf4 - hiwi)" <immd4.informatik.uni-erlangen.de!mlschroe>
To: cs.Princeton.EDU!rayshade-users
Subject: Fbmbump bug


Another bug bites the dust...

In fbmbump.c is a normalize of the modified surface normal missing.
This breaks the costheta and cosalpha calculation and makes the
texture rather useless.

Michael.
---------------------------------------------------------------
Michael Schroeder    mlschroe@faui43.informatik.uni-erlangen.de
main(a){while(a=~getchar())putchar(~a-1/(~(a|32)/13*2-11)*13);}


*** fbmbump.c.orig	Thu Feb 18 15:54:44 1993
--- fbmbump.c	Thu Feb 18 15:55:09 1993
***************
*** 49,52 ****
--- 49,53 ----
  	norm->x += fbm->offset + disp.x * fbm->scale;
  	norm->y += fbm->offset + disp.y * fbm->scale;
  	norm->z += fbm->offset + disp.z * fbm->scale;
+ 	(void)VecNormalize(norm);
  }

----------
Administrivia: rayshade-request@cs.princeton.edu
Mailing list: rayshade-users@cs.princeton.edu